Migrate the Body's highlight variant to semibold #2750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2750 +/- ##
=======================================
Coverage 87.28% 87.28%
=======================================
Files 212 212
Lines 12481 12481
Branches 1678 1678
=======================================
Hits 10894 10894
Misses 1535 1535
Partials 52 52 |
|
Size Change: +3 B (0%) Total Size: 639 kB
ℹ️ View Unchanged
|
sirineJ
reviewed
Oct 30, 2024
| const asAttribute = findAttribute(node, 'as'); | ||
| const weightAttribute = findAttribute(node, 'weight'); | ||
| const replacement = asAttribute ? 'weight="semibold"' : `as="strong"`; | ||
| context.report({ | ||
| node: attribute, | ||
| messageId: 'bodyVariant', | ||
| data: { component, current, replacement }, | ||
| fix: weightAttribute |
There was a problem hiding this comment.
does this mean that if we have a weight attribute besides the variant, we do nothing ?
There was a problem hiding this comment.
We don't apply a fix, but the issue is still flagged. I decided to add this back in case of custom props on styled components.
sirineJ
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
During the design review of the new typography, we noticed that the Body's bold weight has too much visual weight and should be reduced to semibold.
Approach and changes
strongelements andvariant="highlight"as semibold instead of boldvariant="highlight"prop toas="strong", leaving out the superfluousweight="semibold".weight="bold"Definition of done